fix(Log): CI Tooltip 各检查项状态图标按通过/失败/运行中上色#40
Merged
Conversation
tipGlyph 此前返回裸 SVG,缺少 .g-{state} 包裹,导致 Tooltip 内每项检查图标
继承前景色呈单色(仅头部图标上色)。现统一包裹:绿=通过、红=失败、黄=运行中、
灰=未知,与头部及 Log 行图标语义一致。
🤖 Generated with [Claude Code](https://github.com/claude), [CodeX](https://openai.com), [Gemini](https://github.com/apps/gemini-code-assist)
Co-Authored-By: Aurelius Huang<threefish.ai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
PR #37 合入后,Log 视图 CI 状态 Tooltip 内每项检查的状态图标呈单色(灰色),无法区分通过/失败/运行中——如下图:失败的 Quality Gate 与通过的 Test Coverage / SonarQube 图标颜色一致,仅头部汇总图标有红色。
根因
tipGlyph()返回的是裸<svg>,缺少.g-{state}上色包裹。CSS 颜色规则(#ci-tip .g-success/.g-failure/.g-pending)作用于该包裹类,因此只有头部(包了<span class="g g-failure">)上色,各检查行图标继承前景色呈灰色单色。修复
tipGlyph()统一包裹<span class="g g-{state}">,每项检查图标按状态上色,与头部及 Log 主行图标语义一致:testing.iconPassed)testing.iconFailed)testing.iconQueued)descriptionForeground)并补充缺失的
.g-unknownCSS 类。运行中(pending)状态现在在 Tooltip 每行也以黄色旋转图标呈现,与 Log 主行一致。变更
src/adapter/webview/log-webview.ts(+6 / −5),cherry-pick 自工作分支修复 commit,干净叠加于 base(含 feat(Log): Log 视图新增 Checkpointer 选项并默认剔除自动快照提交 #38 Checkpointer),无冲突。验证
pnpm run check-types+pnpm run lint+pnpm run test:unit(280 项)全绿。origin/feature/1.x.x最新(已含 PR feat(Log): 提交记录显示 GitHub CI 最终状态(绿勾/红叉 + 悬停 Tooltip 明细) #37 feat、PR feat(Log): Log 视图新增 Checkpointer 选项并默认剔除自动快照提交 #38 Checkpointer)。🤖 Generated with Claude Code