fix(ci): publish on releases_created (manifest mode)#74
Merged
Conversation
The release-please-action in manifest mode (which we use via `manifest-file: .release-please-manifest.json`) emits `releases_created` (plural) and per-path `<path>--release_created`. There is no top-level `release_created` singular, so the publish steps were silently skipped on every release — including v0.8.0 today. Proof: run https://github.com/TightknitAI/block-kitchen/actions/runs/26129585575 (v0.8.0 merge) shows release-please-action ✅ but every step gated on release_created ⏭ skipped. As a result npm has been stuck at 0.6.1-alpha.0 while GitHub releases continued through 0.7.x and 0.8.0. Switching the conditional to `releases_created` matches what the action actually sets in manifest mode. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
block-kitchen | 800ddb0 | Commit Preview URL Branch Preview URL |
May 20 2026, 04:58 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if:fromrelease_created(singular) toreleases_created(plural).manifest-file: .release-please-manifest.json).Why
The publish steps have been silently skipping on every release because
steps.release.outputs.release_createdis empty in manifest mode — onlyreleases_created(plural) is set, plus per-path.--release_created. A skipped step counts as success, so the job stays green and the failure is invisible.Proof: the v0.8.0 merge run https://github.com/TightknitAI/block-kitchen/actions/runs/26129585575 shows
googleapis/release-please-action@v5✅ then every step after it ⏭ skipped (checkout,setup,lint,typecheck,build:clean,pnpm publish).Impact: npm `@tightknitai/block-kitchen` has been stuck at `0.6.1-alpha.0` (published May 17) while GitHub releases continued through `0.6.2-alpha.0`, `0.6.3-alpha.0`, `0.7.0`, and `0.8.0` (today). Anyone installing from npm gets a version the README no longer describes.
Test plan
🤖 Generated with Claude Code