Chunk abstraction for collections, merge batching, and batches.#744
Draft
frankmcsherry wants to merge 1 commit into
Draft
Chunk abstraction for collections, merge batching, and batches.#744frankmcsherry wants to merge 1 commit into
Chunk abstraction for collections, merge batching, and batches.#744frankmcsherry wants to merge 1 commit into
Conversation
frankmcsherry
force-pushed
the
chunk_basis
branch
5 times, most recently
from
3674e4e to
e7ee7c0
Compare
frankmcsherry
force-pushed
the
chunk_basis
branch
from
e7ee7c0 to
33b8d3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a
trait Chunkthat can be used to back collections, merger batchers, and in a list back a whole batch itself. This is meant to streamline implementation, and remove unnecessary distinctions. Also a bit of an experiment, to see just how small these implementations can get. At the moment .. not tiny .. but not enormous either.