Skip to content

Add rainbow commands#2061

Open
lemonsked wants to merge 6 commits into
TotalFreedom:develfrom
lemonsked:devel
Open

Add rainbow commands#2061
lemonsked wants to merge 6 commits into
TotalFreedom:develfrom
lemonsked:devel

Conversation

@lemonsked

Copy link
Copy Markdown
Member

Add rainbow commands.

Comment thread src/main/java/me/totalfreedom/totalfreedommod/command/Command_rainbowtag.java Outdated
Comment thread src/main/java/me/totalfreedom/totalfreedommod/command/Command_rainbowtag.java Outdated
Wild1145
Wild1145 previously approved these changes Jun 9, 2017
@ghost

ghost commented Jun 9, 2017

Copy link
Copy Markdown

Lemon, are you sure it wont change anything in nicknyan? that is why i made a new color pool!

@Wild1145

Wild1145 commented Jun 9, 2017

Copy link
Copy Markdown
Member

@marcocorriero As long as they are the same colours within the pool, that is all it is, the same set of colours. Its like having two different brand of water, at the end of the day its still just water.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If formatting is the only issue then this looks good.

@Wild1145

Copy link
Copy Markdown
Member

@commodore64x Can you line comment on what formatting you thinks needs to be changed? I didnt spot any...

@mayokek

mayokek commented Jun 10, 2017

Copy link
Copy Markdown

Second eyes are better, I can't spot any.

@JeromSar

Copy link
Copy Markdown
Member

Needs an approved review from @OxLemonxO or @Wild1145.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Testing required.

@ghost

ghost commented Jul 24, 2017

Copy link
Copy Markdown

This was already implemented by directly uploading it to the server (it is NOT on GitHub).

@Wild1145

Copy link
Copy Markdown
Member

@Ivengix Thats not all that helpful...

Comment thread src/main/java/me/totalfreedom/totalfreedommod/command/Command_rainbowtag.java Outdated
@Wild1145 Wild1145 added this to the F (5.1) milestone Jun 22, 2019
@Wild1145 Wild1145 self-assigned this Jun 22, 2019
return true;
}

for (String word : Command_tag.FORBIDDEN_WORDS)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be changed, assuming there is a merge of the 5.0.2 release as the forbidden tags system has changed. That's something I can change though once the PR goes in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants