Test actual LRE in CI#2321
Conversation
|
|
||
| EXPOSE 50051/tcp 50052/tcp | ||
| CMD ["nativelink"] | ||
| ENTRYPOINT ["nativelink"] |
There was a problem hiding this comment.
Making it behave like the nix images
There was a problem hiding this comment.
Using the newer config so I don't get the warnings every time I boot things
| platform_properties: { | ||
| cpu_count: { | ||
| query_cmd: "nproc", | ||
| values: [], |
There was a problem hiding this comment.
Path isn't present on the nix images
| exit_code = ?execution_result.exit_code, | ||
| stdout = ?stdout[..min(stdout.len(), 1000)], | ||
| stderr = ?stderr[..min(stderr.len(), 1000)], | ||
| command = ?command_proto.arguments, |
There was a problem hiding this comment.
The error was just Command returned non-zero exit code, exit_code: 1, stdout: "", stderr: "bootstrap_process_wrapper: execvp: No such file or directory\n" or similar, now we get the full command
| let program = self.canonicalise_path(args[0], &command_proto.working_directory)?; | ||
| let program = self | ||
| .canonicalise_path(args[0], &command_proto.working_directory) | ||
| .err_tip(|| format!("Canonicalisation failure. Command={args:#?}"))?; |
There was a problem hiding this comment.
Error executing action, err: Error { code: NotFound, messages: ["No such file or directory (os error 2)", "Could not canonicalize path for command root /bin/bash."] } isn't very useful without knowing what was trying to invoke bash
| nix run .#nativelink-worker-init.copyTo docker-daemon:local-worker-init:latest | ||
|
|
||
| - name: Compile NativeLink with NativeLink | ||
| timeout-minutes: 5 # FIXME: Reset to 60 before merge |
1 participant
Description
We previously had LRE testing, but it was a mix of trivial examples and buggy k8s-in-CI setups long commented out. This PR spins up a docker compose setup with the current branch's nix images and tries to build them, which will make it much easier to make improvements to those.
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
CI, bunch of local
docker composeandbazel testsimilar to the CI steps.Checklist
bazel test //...passes locallygit amendsee some docsThis change is