Skip to content

Add cache metrics#2344

Open
MarcusSorealheis wants to merge 8 commits into
TraceMachina:mainfrom
MarcusSorealheis:add-otel-config-options
Open

Add cache metrics#2344
MarcusSorealheis wants to merge 8 commits into
TraceMachina:mainfrom
MarcusSorealheis:add-otel-config-options

Conversation

@MarcusSorealheis
Copy link
Copy Markdown
Collaborator

@MarcusSorealheis MarcusSorealheis commented May 18, 2026 •
edited
Loading

Description

Re-adds cache metrics to the metrics implementation via a store wrapper that does not exist unless enabled.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

//nativelink-store:integration_tests/cache_metrics_store_test_test

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@MarcusSorealheis
Copy link
Copy Markdown
Collaborator Author

MarcusSorealheis commented May 18, 2026

/build-image

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

Image built and pushed!

ghcr.io/TraceMachina/nativelink:28e5fa2

palfrey
palfrey requested changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@palfrey palfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, and I'm also seeing a pile of https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#single_match_else warnings which we should probably either fix or explicitly ignore

Comment thread nativelink-store/src/cache_metrics_store.rs Outdated
@MarcusSorealheis @palfrey
Update nativelink-store/src/cache_metrics_store.rs
15efde4 
Co-authored-by: Tom Parker-Shemilt <palfrey@tevp.net>
@MarcusSorealheis MarcusSorealheis requested a review from palfrey May 18, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@palfrey palfrey palfrey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarcusSorealheis @palfrey