simple_scheduler_state_manager: count worker disconnects toward max_job_retries#2352
Open
amankrx wants to merge 1 commit into
Open
simple_scheduler_state_manager: count worker disconnects toward max_job_retries#2352amankrx wants to merge 1 commit into
amankrx wants to merge 1 commit into
Conversation
MarcusSorealheis
requested changes
May 21, 2026
| ..ExecutionMetadata::default() | ||
| }, | ||
| error: Some(make_err!( | ||
| Code::Aborted, |
Collaborator
There was a problem hiding this comment.
I was re-reading this one. This is the wrong error code. Code::Aborted is for concurrency/transaction conflicts. For an action that failed because the worker repeatedly died running it, the right code is INTERNAL (the safe generic).
If we could verify what the failure mode was, like OOM or something else, we could get more specific like RESOURCE_EXHAUSTED.
Collaborator
There was a problem hiding this comment.
Can check here for reference: https://github.com/grpc/grpc/blob/master/doc/statuscodes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid worker disconnects that keeps on running the build forever.
Fixes # (issue)
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
Added tests and tested it in a working build environment.
Please also list any relevant details for your test configuration
Checklist
bazel test //...passes locallygit amendsee some docsThis change is