fix: technical debt#107
Merged
Merged
Conversation
…line dependencies
…d remove redundant command Remove unused messages property from CreditCardController configuration
|
luisguananga-continuum
approved these changes
Jun 1, 2026
Matiasnickolas
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request introduces several improvements to the development environment, frontend UX, and code organization. The most significant changes are the addition of a Dev Container setup for consistent local development, a refactor of the credit card animation logic to use Stimulus controllers, and enhancements to sidebar and scrolling behaviors. Additionally, some optional input fields were removed from the installments forms to simplify the UI.
Development Environment Improvements:
.devcontainer/devcontainer.json,.devcontainer/devcontainer-lock.json, and a setup script (post-create.sh), providing a preconfigured Docker-based environment for Ruby 3.2.2 development. This includes recommended VS Code settings and extensions for a smoother onboarding experience. [1] [2] [3]README.mdwith detailed instructions for using the Dev Container, including troubleshooting tips and platform-specific notes.Frontend Refactors and Enhancements:
credit_card_controller.js), improving maintainability and separation of concerns. The import is now managed viaimportmap.rband the controller is attached viadata-controllerin the partial. [1] [2] [3] [4]Sidebar and UI/UX Improvements:
application.css, including better handling of max heights, scrollbars, and sidebar collapse/expand transitions for a more polished user experience. [1] [2] [3] [4]Installments Form Simplification:
deferredPeriodIndex,gracePeriod) from the installments forms and their associated JavaScript logic in bothtransaccion_completa_mallandtransaccion_completa_mall_diferidaviews, streamlining the user interface. [1] [2] [3] [4]