Skip to content

fix: technical debt#107

Merged
victormendoza96 merged 11 commits into
developfrom
fix/technical-debt
Jun 2, 2026
Merged

fix: technical debt#107
victormendoza96 merged 11 commits into
developfrom
fix/technical-debt

Conversation

@victormendoza96
Copy link
Copy Markdown
Contributor

This pull request introduces several improvements to the development environment, frontend UX, and code organization. The most significant changes are the addition of a Dev Container setup for consistent local development, a refactor of the credit card animation logic to use Stimulus controllers, and enhancements to sidebar and scrolling behaviors. Additionally, some optional input fields were removed from the installments forms to simplify the UI.

Development Environment Improvements:

  • Added full Dev Container support with .devcontainer/devcontainer.json, .devcontainer/devcontainer-lock.json, and a setup script (post-create.sh), providing a preconfigured Docker-based environment for Ruby 3.2.2 development. This includes recommended VS Code settings and extensions for a smoother onboarding experience. [1] [2] [3]
  • Updated the README.md with detailed instructions for using the Dev Container, including troubleshooting tips and platform-specific notes.

Frontend Refactors and Enhancements:

  • Migrated the credit card animation (jessepollak/card) from inline JavaScript in the view to a dedicated Stimulus controller (credit_card_controller.js), improving maintainability and separation of concerns. The import is now managed via importmap.rb and the controller is attached via data-controller in the partial. [1] [2] [3] [4]
  • Removed the CDN-based card.js and card.min.css includes from the layout, as the library is now vendored and managed locally.

Sidebar and UI/UX Improvements:

  • Enhanced sidebar and scrolling behaviors in application.css, including better handling of max heights, scrollbars, and sidebar collapse/expand transitions for a more polished user experience. [1] [2] [3] [4]

Installments Form Simplification:

  • Removed optional fields (deferredPeriodIndex, gracePeriod) from the installments forms and their associated JavaScript logic in both transaccion_completa_mall and transaccion_completa_mall_diferida views, streamlining the user interface. [1] [2] [3] [4]
image

@victormendoza96 victormendoza96 self-assigned this Jun 1, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 1, 2026

@victormendoza96 victormendoza96 merged commit 470dd2f into develop Jun 2, 2026
6 checks passed
@victormendoza96 victormendoza96 deleted the fix/technical-debt branch June 2, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants