fix(compose): keep the MySQL root password out of the healthcheck process list#247
Open
NX1X wants to merge 1 commit into
Open
fix(compose): keep the MySQL root password out of the healthcheck process list#247NX1X wants to merge 1 commit into
NX1X wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe MySQL container healthcheck now sets Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The db healthcheck passes the root password with -p on the command line:
test: mysqladmin ping -p$$MYSQL_ROOT_PASSWORD -h 127.0.0.1
Anything that can list processes in that container's PID namespace - docker top ghost-db, ps from inside the container, or a compromised sidecar sharing the namespace - can read MYSQL_ROOT_PASSWORD in plaintext from the mysqladmin argv.
This passes the password via the MYSQL_PWD env var instead, which mysqladmin reads automatically and which never appears in the process list:
test: MYSQL_PWD="$$MYSQL_ROOT_PASSWORD" mysqladmin ping -h 127.0.0.1
Behaviour is identical (same user, same ping); only the password stops leaking into argv. MySQL's own docs advise against -p on the CLI for exactly this reason. docker compose config still validates.