fix: prevent proactive replies during explicit mentions#9
Open
SebastianBoehler wants to merge 1 commit into
Open
fix: prevent proactive replies during explicit mentions#9SebastianBoehler wants to merge 1 commit into
SebastianBoehler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the likely duplicate-response path from Discord proactive monitoring overlapping with an explicit bot mention.
Changes:
StudyBot.has_active_mention_task(channel_id)helper for runtime coordination.ProactiveMonitorskip channels that currently have active mention work.ProactiveMonitorskip latest human messages that mention the bot, marking them processed so proactive checks do not respond after the mention run finishes.Why
The thread report points to proactive replies landing while an explicit mention-triggered Codex run is still working or later timing out. The previous safeguards only covered mention dispatch itself; proactive checks could still inspect the same mention message and produce a second response.
This PR prevents the proactive monitor from treating explicit bot mentions as proactive opportunities.
Verification
ruff check .pyrightpytestNotes
This addresses the proactive-overlap cause discussed in Discord. The broader cross-process durable idempotency idea in #8 may still be useful as a separate hardening step if multiple gateway instances are expected to consume the same Discord bot token.
Refs #8