flush 忘れを修正#16
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR bumps the crate version to 1.0.1 and refactors the ChangesMarker Flushing Fix
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect #line placement in the bundling rewrite pass by ensuring pending real source markers are flushed not only before normal code lines, but also immediately before restored #include lines (converted from #pragma RISUNDLE_DUMMY ...). This aligns restored includes with their original source locations, addressing Issue #15.
Changes:
- Always flush a pending real linemarker before emitting any surviving output line (including restored
#include). - Update module-level documentation to reflect the corrected marker emission behavior.
- Add a regression test for flushing pending markers before a mid-stream restored include; bump crate version to 1.0.1.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/bundle/rewrite.rs |
Flushes pending markers before restored includes and adds a regression test to prevent #line mis-association. |
Cargo.toml |
Bumps crate version to 1.0.1 for the fix release. |
Cargo.lock |
Updates lockfile to reflect the new crate version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix #15
Summary by CodeRabbit
Chores
Bug Fixes