Skip to content

README 英語対応#19

Merged
TwoSquirrels merged 2 commits into
mainfrom
i18n
Jun 10, 2026
Merged

README 英語対応#19
TwoSquirrels merged 2 commits into
mainfrom
i18n

Conversation

@TwoSquirrels

@TwoSquirrels TwoSquirrels commented Jun 9, 2026

Copy link
Copy Markdown
Owner

close #13

Summary by CodeRabbit

  • Documentation

    • Added Japanese documentation for README and specification.
    • Updated English documentation in README and specification files.
    • Standardized terminology across all documentation.
  • Chores

    • Standardized terminology in code comments throughout the codebase.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR introduces multilingual documentation support for risundle (issue #13) by adding Japanese README and specification files, rewriting English documentation for clarity, and standardizing terminology across all documentation and code comments.

Changes

Documentation and Consistency Updates

Layer / File(s) Summary
Japanese Documentation
README.ja.md, docs/spec.ja.md
New Japanese documentation covering risundle features, installation, CLI usage, configuration, benchmarks, and implementation details. Specification document details library subcommands, bundling configuration, change detection, output format, and internal tags.json structure.
English Documentation Updates
README.md, docs/spec.md, docs/architecture.md
English README is restructured with improved sections for features, installation, usage, and configuration. English specification provides command behavior details, configuration resolution, and tags.json field documentation. Architecture documentation unifies terminology to lowercase "tree-shaking".
Code and Test Comment Standardization
src/bundle/inventory.rs, src/bundle/linemarker.rs, src/bundle/mod.rs, src/library/dummy.rs, src/library/identifiers.rs, tests/cli.rs, tests/libraries.rs
Module-level documentation comments and test comments across source and test files are updated to consistently use lowercase "tree-shaking" instead of capitalized variants.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

📚 A bundler's voice now speaks in two,

With Japanese and English, fresh and true!

Consistency blooms in each small note,

As "tree-shaking" finds a proper coat. 🌲

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes out-of-scope changes: terminology standardization updates across multiple source files (tree-shaking capitalization in comments, docs, and tests) are unrelated to the README multilingual support objective. Separate the terminology standardization changes into a distinct PR, keeping this PR focused exclusively on README multilingual support (README.md, README.ja.md, and spec files).
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'README 英語対応' directly relates to the PR's main objective of adding English support to the README documentation.
Linked Issues check ✅ Passed The PR successfully implements multilingual README support by adding English content to README.md and creating README.ja.md for Japanese, fully addressing issue #13 requirements for Japanese and English documentation.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch i18n

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (4)
README.ja.md (2)

53-55: ⚡ Quick win

Add language identifier to fenced code block.

The fenced code block lacks a language identifier. Adding text will improve syntax highlighting and rendering consistency.

📝 Suggested fix
-```
+```text
 risundle [OPTIONS] <FILE> [-- <COMPILER OPTIONS>...]
</details>

<details>
<summary>🤖 Prompt for AI Agents</summary>

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @README.ja.md around lines 53 - 55, The fenced code block containing the
command example "risundle [OPTIONS] [-- ...]" should
include a language identifier to improve syntax highlighting; update the opening
triple-backtick to include "text" (i.e., ```text) so the block becomes a fenced
text code block.


</details>

<!-- cr-comment:v1:5be4ff0a7d479b3cf7149989 -->

_Source: Linters/SAST tools_

---

`77-79`: _⚡ Quick win_

**Add language identifier to fenced code block.**

The fenced code block lacks a language identifier. Adding `text` will improve syntax highlighting and rendering consistency.






<details>
<summary>📝 Suggested fix</summary>

```diff
-```
+```text
 risundle library <SUBCOMMAND>
 ```
```
</details>

<details>
<summary>🤖 Prompt for AI Agents</summary>

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @README.ja.md around lines 77 - 79, Update the fenced code block that
currently contains "risundle library " to include a language
identifier by changing the opening fence to use "text" (i.e., replace the
opening "" with "text") so the block becomes a markdown fenced code block
with the text language for proper highlighting and rendering.


</details>

<!-- cr-comment:v1:2a463c3b371e53ef4860746f -->

_Source: Linters/SAST tools_

</blockquote></details>
<details>
<summary>README.md (2)</summary><blockquote>

`77-79`: _⚡ Quick win_

**Add language identifier to fenced code block.**

The fenced code block lacks a language identifier. Adding `text` will improve syntax highlighting and rendering consistency.






<details>
<summary>📝 Suggested fix</summary>

```diff
-```
+```text
 risundle library <SUBCOMMAND>
 ```
```
</details>

<details>
<summary>🤖 Prompt for AI Agents</summary>

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @README.md around lines 77 - 79, The fenced code block containing "risundle
library " needs a language identifier; update the markdown fence to
use "text" (i.e., change the opening totext) so the snippet "risundle
library " is rendered with proper highlighting/consistency in the
README.


</details>

<!-- cr-comment:v1:2a87d09781a8ac0318cf4236 -->

_Source: Linters/SAST tools_

---

`53-55`: _⚡ Quick win_

**Add language identifier to fenced code block.**

The fenced code block lacks a language identifier. Adding `text` will improve syntax highlighting and rendering consistency.






<details>
<summary>📝 Suggested fix</summary>

```diff
-```
+```text
 risundle [OPTIONS] <FILE> [-- <COMPILER OPTIONS>...]
 ```
```
</details>

<details>
<summary>🤖 Prompt for AI Agents</summary>

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @README.md around lines 53 - 55, The fenced code block containing the command
string "risundle [OPTIONS] [-- ...]" should include a
language identifier for proper highlighting; update the triple-backtick fence to
use "text" (i.e., ```text) so the README's example renders consistently and
improves syntax highlighting for that command snippet.


</details>

<!-- cr-comment:v1:5802e280424c2eab6f7a3f18 -->

_Source: Linters/SAST tools_

</blockquote></details>

</blockquote></details>

<details>
<summary>🤖 Prompt for all review comments with AI agents</summary>

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @README.ja.md:

  • Around line 53-55: The fenced code block containing the command example
    "risundle [OPTIONS] [-- ...]" should include a language
    identifier to improve syntax highlighting; update the opening triple-backtick to
    include "text" (i.e., ```text) so the block becomes a fenced text code block.
  • Around line 77-79: Update the fenced code block that currently contains
    "risundle library " to include a language identifier by changing the
    opening fence to use "text" (i.e., replace the opening "" with "text") so
    the block becomes a markdown fenced code block with the text language for proper
    highlighting and rendering.

In @README.md:

  • Around line 77-79: The fenced code block containing "risundle library
    " needs a language identifier; update the markdown fence to use
    "text" (i.e., change the opening totext) so the snippet "risundle
    library " is rendered with proper highlighting/consistency in the
    README.
  • Around line 53-55: The fenced code block containing the command string
    "risundle [OPTIONS] [-- ...]" should include a language
    identifier for proper highlighting; update the triple-backtick fence to use
    "text" (i.e., ```text) so the README's example renders consistently and improves
    syntax highlighting for that command snippet.

</details>

---

<details>
<summary>ℹ️ Review info</summary>

<details>
<summary>⚙️ Run configuration</summary>

**Configuration used**: defaults

**Review profile**: CHILL

**Plan**: Pro

**Run ID**: `63ac8391-4a01-481e-8992-28a17a1f3dd0`

</details>

<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between 54def0dd88e908291920bb4c04d35d3585f71614 and d7dedf46eddb5cb32ad03a3cfdafc42157131280.

</details>

<details>
<summary>📒 Files selected for processing (12)</summary>

* `README.ja.md`
* `README.md`
* `docs/architecture.md`
* `docs/spec.ja.md`
* `docs/spec.md`
* `src/bundle/inventory.rs`
* `src/bundle/linemarker.rs`
* `src/bundle/mod.rs`
* `src/library/dummy.rs`
* `src/library/identifiers.rs`
* `tests/cli.rs`
* `tests/libraries.rs`

</details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

@TwoSquirrels TwoSquirrels merged commit dcffdc1 into main Jun 10, 2026
9 checks passed
@TwoSquirrels TwoSquirrels deleted the i18n branch June 10, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README 多言語対応

1 participant