fix(ui5-carousel): fix navigation animation#13762
Open
TeodorTaushanov wants to merge 2 commits into
Open
Conversation
TeodorTaushanov
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
|
🚀 Deployed on https://pr-13762--ui5-webcomponents-preview.netlify.app |
TeodorTaushanov
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
dimovpetar
requested changes
Jul 7, 2026
| }); | ||
|
|
||
| btnNavigate.addEventListener("click", function() { | ||
| carousel._onResize(); |
Member
There was a problem hiding this comment.
Can u replace carousel._onResize(); with something public, like setting the changing the width through CSS?
Comment on lines
400
to
415
| _onResize() { | ||
| const previousItemsPerPage = this.effectiveItemsPerPage; | ||
|
|
||
| // Set the resizing flag to suppress animation while resizing | ||
| this._resizing = true; | ||
|
|
||
| // Change transitively effectiveItemsPerPage by modifying _width | ||
| this._width = this.offsetWidth; | ||
| this._itemWidth = Math.floor(this._width / this.effectiveItemsPerPage); | ||
|
|
||
| // Items per page did not change, | ||
| // therefore page index does not need to be re-adjusted | ||
| if (this.effectiveItemsPerPage === previousItemsPerPage) { | ||
| this._updateVisibleItems(this._currentPageIndex); | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
_onResize() {
const previousItemsPerPage = this.effectiveItemsPerPage;
// Set the resizing flag to suppress animation while resizing
const previousWidth = this._width;
this._resizing = true;
// Change transitively effectiveItemsPerPage by modifying _width
this._width = this.offsetWidth;
this._itemWidth = Math.floor(this._width / this.effectiveItemsPerPage);
// Items per page did not change,
// therefore page index does not need to be re-adjusted
if (this._width === previousWidth && this.effectiveItemsPerPage === previousItemsPerPage) {
this._resizing = false;
this._updateVisibleItems(this._currentPageIndex);
return;
}| return; | ||
| } | ||
|
|
||
| this._resizing = false; |
Member
There was a problem hiding this comment.
To keep _changePageIndex clean, without this side effect, I proposed another handling in _onResize
| cy.get<Carousel>("#carousel") | ||
| .then($carousel => { | ||
| const carousel = $carousel[0]; | ||
| carousel._onResize(); |
Member
There was a problem hiding this comment.
Try to change the width of the carousel via CSS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13625