Skip to content

CURA-12556 formula parser in cura engine#21306

Merged
HellAholic merged 11 commits intomainfrom
CURA-12556_formula-parser-in-CuraEngine
Mar 25, 2026
Merged

CURA-12556 formula parser in cura engine#21306
HellAholic merged 11 commits intomainfrom
CURA-12556_formula-parser-in-CuraEngine

Conversation

@wawanbreton
Copy link
Copy Markdown
Contributor

This PR moves the GCode-template replacement algorithm from the Cura front-end to the engine. This allows for more flexibility because the engine has more information when resolving the templates. Especially for the extruders start/end GCodes, which can now be different between each layer.

Requires Ultimaker/CuraEngine#2274
CURA-12556

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 16, 2026

Test Results

24 572 tests   - 20   24 570 ✅  - 20   52s ⏱️ -1s
     1 suites ± 0        2 💤 ± 0 
     1 files   ± 0        0 ❌ ± 0 

Results for commit 1914208. ± Comparison against base commit d0b5884.

This pull request removes 20 tests.
tests.Machines.TestStartEndGCode ‑ test_startEndGCode_replace[Basic replacement]
tests.Machines.TestStartEndGCode ‑ test_startEndGCode_replace[Condition expression without start]
tests.Machines.TestStartEndGCode ‑ test_startEndGCode_replace[Conditional expression with elsif]
tests.Machines.TestStartEndGCode ‑ test_startEndGCode_replace[Conditional expression with extruder index specified by formula]
tests.Machines.TestStartEndGCode ‑ test_startEndGCode_replace[Conditional expression with extruder index specified by setting]
tests.Machines.TestStartEndGCode ‑ test_startEndGCode_replace[Conditional expression with extruder setting directly specified by index 0]
tests.Machines.TestStartEndGCode ‑ test_startEndGCode_replace[Conditional expression with extruder setting directly specified by index 1]
tests.Machines.TestStartEndGCode ‑ test_startEndGCode_replace[Conditional expression with global setting]
tests.Machines.TestStartEndGCode ‑ test_startEndGCode_replace[Conditional expression with missing end character]
tests.Machines.TestStartEndGCode ‑ test_startEndGCode_replace[Formula inside a conditional expression]
…

♻️ This comment has been updated with latest results.

Comment thread plugins/CuraEngineBackend/StartSliceJob.py
@HellAholic HellAholic merged commit 2cb5364 into main Mar 25, 2026
8 checks passed
@HellAholic HellAholic deleted the CURA-12556_formula-parser-in-CuraEngine branch March 25, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants