Skip to content

CURA-10381 Add setting to enable infill splitting close to seam#21349

Merged
HellAholic merged 12 commits into5.13from
CURA-10381_start-or-end-infill-close-to-seam
Mar 27, 2026
Merged

CURA-10381 Add setting to enable infill splitting close to seam#21349
HellAholic merged 12 commits into5.13from
CURA-10381_start-or-end-infill-close-to-seam

Conversation

@wawanbreton
Copy link
Copy Markdown
Contributor

@wawanbreton wawanbreton commented Jan 30, 2026

This PR adds a setting to selectively enable the "Split Infill Close to Seam" feature, which allows reducing the travel move between the infill and outer wall by splitting the infill line close to wher it should end, providing a proper end position.

Requires Ultimaker/CuraEngine#2279
CURA-10381

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 30, 2026

Test Results

24 592 tests   24 587 ✅  51s ⏱️
     1 suites       2 💤
     1 files         3 ❌

For more details on these failures, see this check.

Results for commit 5636887.

♻️ This comment has been updated with latest results.

@HellAholic HellAholic changed the base branch from main to 5.13 March 16, 2026 14:32
@wawanbreton wawanbreton force-pushed the CURA-10381_start-or-end-infill-close-to-seam branch from 77f1838 to fe65587 Compare March 17, 2026 16:22
wawanbreton and others added 4 commits March 17, 2026 16:24
CURA-10381
Since randomize infill and split infill close to seam don't make sense to be used together, remove this possibility by choosing either none or one of them.
Comment thread resources/definitions/fdmprinter.def.json Outdated
Comment thread resources/definitions/ultimaker_s8.def.json Outdated
wawanbreton and others added 2 commits March 23, 2026 14:47
Co-authored-by: Casper Lamboo <casperlamboo@gmail.com>
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Comment thread resources/definitions/ultimaker_s8.def.json
@github-actions github-actions Bot dismissed their stale review March 25, 2026 13:42

No Clang-Tidy warnings found so I assume my comments were addressed

@HellAholic HellAholic merged commit 5842056 into 5.13 Mar 27, 2026
13 of 16 checks passed
@HellAholic HellAholic deleted the CURA-10381_start-or-end-infill-close-to-seam branch March 27, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants