fix: implement secure XML parsing in plugin readers#21435
Open
RinZ27 wants to merge 1 commit intoUltimaker:mainfrom
Open
fix: implement secure XML parsing in plugin readers#21435RinZ27 wants to merge 1 commit intoUltimaker:mainfrom
RinZ27 wants to merge 1 commit intoUltimaker:mainfrom
Conversation
github-actions
Bot
added
the
PR: Community Contribution 👑
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements secure XML parsing across several plugin readers, including AMF, X3D, 3MF Workspace, and XML Material Profile.
By default, the native Python
xml.etree.ElementTreelibrary is susceptible to XML External Entity (XXE) attacks because it does not disable entity expansion. I have implemented a "no-dependency" fix by explicitly configuring anET.XMLParserwith entity resolution disabled (parser.entity = {}). This ensures that user-supplied model and profile files are parsed safely without introducing new external requirements.This improves the overall robustness of the application when handling untrusted files from external sources.
Type of change
How Has This Been Tested?
The changes were verified by ensuring that the safe parser configuration correctly handles standard XML input while preventing the resolution of external entities. The logic follows established security best practices for the standard library's XML implementation.
Test Configuration:
Checklist: