Skip to content

CURA-13005 Properly display empty layers#21456

Merged
HellAholic merged 7 commits intomainfrom
CURA-13005
Apr 20, 2026
Merged

CURA-13005 Properly display empty layers#21456
HellAholic merged 7 commits intomainfrom
CURA-13005

Conversation

@wawanbreton
Copy link
Copy Markdown
Contributor

Since the associated engine changes now allow fully empty layers being generated, we now handle this case properly in the UI and display a disabled slider when the layer is empty.

Comes with Ultimaker/CuraEngine#2297
CURA-13005

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

Test Results

24 572 tests  ±0   24 570 ✅ ±0   52s ⏱️ -1s
     1 suites ±0        2 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 6583529. ± Comparison against base commit 042b38e.

♻️ This comment has been updated with latest results.

@wawanbreton wawanbreton marked this pull request as ready for review March 9, 2026 15:31
Copy link
Copy Markdown
Member

@rburema rburema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we want this in main or in the 5.13? (I think main is sensible in this case...)

Comment thread plugins/SimulationView/LayerSlider.qml Outdated
Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
@HellAholic HellAholic merged commit 6651888 into main Apr 20, 2026
9 checks passed
@HellAholic HellAholic deleted the CURA-13005 branch April 20, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants