bugfix/725: Update PayPal disconnect disclaimer and show merchant status banners

[superdav42]

Summary

• t523a (t523a: Update PayPal disconnect confirmation to use required disclaimer #727): Replace generic disconnect confirm dialog with PayPal's required disclaimer: "Disconnecting your PayPal account will prevent you from offering PayPal services and products on your website. Do you wish to continue?"
• t523b (t523b: Show onboarding failure messages when merchant status is invalid #728): Always persist payments_receivable and email_confirmed after OAuth (previously only stored when truthy). Display PayPal's exact required error banners in render_oauth_connection() when either flag is false.

Changes

inc/gateways/class-paypal-oauth-handler.php

• Always save payments_receivable and email_confirmed settings (defaulting to true when absent from API response)
• Show one-time flash notice on OAuth redirect when status is incomplete

inc/gateways/class-paypal-rest-gateway.php

• Add persistent error banners in render_oauth_connection() using PayPal's exact required text
• Update disconnect confirm dialog text to PayPal's required wording
• Fix JS indentation in disconnect handler

Acceptance Criteria

• Disconnect confirm dialog uses PayPal's exact required wording (t523a: Update PayPal disconnect confirmation to use required disclaimer #727)
• Error banner shown when payments_receivable is false with PayPal's exact text (t523b: Show onboarding failure messages when merchant status is invalid #728)
• Error banner shown when email_confirmed is false with PayPal's exact text (t523b: Show onboarding failure messages when merchant status is invalid #728)

Closes #727
Closes #728

Part of #725

---

aidevops.sh v3.5.556 plugin for OpenCode v1.3.0 with claude-sonnet-4-6 spent 15h 10m and 13,232 tokens on this as a headless worker.

[coderabbitai]

Warning

Rate limit exceeded

@superdav42 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 37 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 20 minutes and 37 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7754b181-0c63-4335-b3e4-2baefd3d5350

📥 Commits

Reviewing files that changed from the base of the PR and between 03bdae6 and 84680eb.

📒 Files selected for processing (2)

• inc/gateways/class-paypal-oauth-handler.php
• inc/gateways/class-paypal-rest-gateway.php

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bugfix/725-paypal-ppcp-compliance

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

• Build: ultimate-multisite
• ⬇️ Download from GitHub Actions
• ⬇️ Download without Github Account (nightly.link)

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

[github-actions]

Performance Test Results

Performance test results for 708589f are in 🛎️!

Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown.

URL: /

Run	DB Queries	Memory	Before Template	Template	WP Total	LCP	TTFB	LCP - TTFB
0	41 (+1 / +2% )	37.78 MB	860.50 ms	179.50 ms	1084.50 ms	1996.00 ms (-64.00 ms / -3% )	1892.30 ms (-84.35 ms / -4% )	92.60 ms
1	56	49.02 MB	898.00 ms (-21.50 ms / -2% )	151.00 ms	1047.00 ms (-23.00 ms / -2% )	2044.00 ms	1960.60 ms	83.10 ms