Skip to content

opt: remove unnecessary max() op when tweaking system shadow#788

Merged
sindharta merged 4 commits intomasterfrom
opt-tweak-shadow
Apr 14, 2026
Merged

opt: remove unnecessary max() op when tweaking system shadow#788
sindharta merged 4 commits intomasterfrom
opt-tweak-shadow

Conversation

@sindharta
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Optimizes URP toon body shading by simplifying the system shadow “tweak” clamp operation.

Changes:

  • Simplified TweakShadow() by removing the max(..., 0.0001) clamp and relying solely on saturate()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread com.unity.toonshader/Runtime/Shaders/URP/UniversalToonBody.hlsl
Comment thread com.unity.toonshader/Runtime/Shaders/URP/UniversalToonBody.hlsl Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sindharta sindharta merged commit b63d983 into master Apr 14, 2026
26 checks passed
@sindharta sindharta deleted the opt-tweak-shadow branch April 14, 2026 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants