Fixing a crash when exiting or re-entering play mode#6296
Open
Codengineer wants to merge 2 commits into
Open
Conversation
Fixes UUM-135678
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes UUM-135678. The crash occurs because Academy.HandleOnPlayModeChanged only handles ExitingEditMode, not ExitingPlayMode. This means when you exit play mode:
Proposed change(s)
Added ExitingPlayMode handling so the Academy properly disposes all ModelRunner instances (and their Worker objects with native memory) before domain reload occurs. This ensures Academy.Dispose() → ModelRunner.Dispose() → Worker.Dispose() → CPUTensorData.Dispose() all run on the main thread during the ExitingPlayMode phase, before domain reload triggers GC finalization on background threads.
Retested intensively enter-exit play mode cycle and could not get it to crash again while it was crashing almost all the times before.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://jira.unity3d.com/browse/UUM-135678?filter=-1
Types of change(s)
Checklist
Other comments