Skip to content

test: enable gradual rollout strategy tests in feature spec#11537

Merged
krzychukula merged 9 commits intomainfrom
test/enable-strategy-test
Mar 17, 2026
Merged

test: enable gradual rollout strategy tests in feature spec#11537
krzychukula merged 9 commits intomainfrom
test/enable-strategy-test

Conversation

@krzychukula
Copy link
Copy Markdown
Contributor

@krzychukula krzychukula commented Mar 10, 2026

About the changes

This tries to bring back failing test

Claude thinks it's failing because of #11482

EditControls is defined as a component inside the render function (line 80). On every re-render of ProjectEnvironmentStrategyDraggableItem — triggered by useScheduledChangeRequestsWithStrategy or useStrategyChangesFromRequest completing — React sees a new function reference for EditControls, treats it as a different component, and unmounts + remounts it. This resets anchorEl to null in MenuStrategyRemove, closing the menu before Cypress finds STRATEGY_FORM_REMOVE_ID.

The fix is to inline the JSX directly instead of using an inline sub-component:

But, fixing it doesn't help 🤷

Closes

Important files

Discussion points

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 10, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@krzychukula krzychukula marked this pull request as ready for review March 10, 2026 16:46
@gastonfournier gastonfournier moved this from New to In Progress in Issues and PRs Mar 11, 2026
@krzychukula krzychukula force-pushed the test/enable-strategy-test branch from 433183c to 0473b77 Compare March 11, 2026 07:46
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Issues and PRs Mar 11, 2026
@krzychukula krzychukula reopened this Mar 11, 2026
@github-project-automation github-project-automation Bot moved this from Done to New in Issues and PRs Mar 11, 2026
@gastonfournier gastonfournier moved this from New to In Progress in Issues and PRs Mar 11, 2026
Copy link
Copy Markdown
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@github-project-automation github-project-automation Bot moved this from In Progress to Approved PRs in Issues and PRs Mar 17, 2026
@krzychukula krzychukula merged commit 9f28c75 into main Mar 17, 2026
17 checks passed
@krzychukula krzychukula deleted the test/enable-strategy-test branch March 17, 2026 11:43
@github-project-automation github-project-automation Bot moved this from Approved PRs to Done in Issues and PRs Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants