test: fix test suite bugs#407
Open
leowla wants to merge 4 commits into
Open
Conversation
- Fix Express error handler arity in imageApi (2 params → 4; Express requires exactly 4 to recognise error-handling middleware) - Reset nextFunction mock between tests in scenarioAuth to prevent call-count bleed across test cases - Remove deprecated useNewUrlParser/useUnifiedTopology options from sceneDao that generated driver warnings - Add missing Access document deletion assertion to scenario DELETE test - Replace Object.entries(array).map(([_, doc]) => doc) in user.js with .map(doc => doc._id), which passed Mongoose documents where ObjectIds were expected - Configure no-unused-vars argsIgnorePattern for underscore-prefixed params; remove now-redundant eslint-disable comment in user.js
Add src/test/mongoSetup.js with two composable functions:
useMongoMemoryServer() registers beforeAll/afterEach/afterAll lifecycle
hooks for MongoMemoryServer; useExpressServer(configureApp) registers
beforeAll/afterAll for an Express server and returns a ctx object whose
port is populated at test time.
Replace ~15 lines of duplicated boilerplate in all five test files with
two calls at the top of each describe block. Also fixes a latent teardown
race: the original server.close(async () => {...}) passed an async
callback that Jest never awaited; the helper uses a Promise-wrapped close
so mongoose.disconnect and mongoServer.stop are properly sequenced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Fix bugs and dedupe Mongoose connection code in test suite
Risk
Low. We can rely on the test suite!!!
Potential risk with user.js fix which corrects broken behaviour (user assignment was passing document objects instead of IDs to the query)
Checklist