Skip to content

Vps 40/dropdown trunucation#409

Open
GogaIV wants to merge 5 commits into
masterfrom
VPS-40/dropdown-trunucation
Open

Vps 40/dropdown trunucation#409
GogaIV wants to merge 5 commits into
masterfrom
VPS-40/dropdown-trunucation

Conversation

@GogaIV
Copy link
Copy Markdown
Contributor

@GogaIV GogaIV commented May 21, 2026

Issue

drop down truncation

Solution

it was a little small i felt you could only fit 22 chars so i expanded it and added a scroll for overflow
I also added an extra quick command for lint and prettier on the side cause it saves a few seconds

Images

image

Risk

None

Checklist

  • Acceptance criteria met
  • Wiki documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous integration build passing

@linear
Copy link
Copy Markdown

linear Bot commented May 21, 2026

VPS-40

Copy link
Copy Markdown
Member

@leowla leowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to wrap text here.

e.g.
Image

https://primer.style/accessibility/patterns/truncation/#interactive-elements

Do not truncate text if it contains focusable elements such as links, buttons, and mentions/tags.

If you experience this challenge, some potential design alternatives are:

  • Wrap text instead of truncate (so long as focus does not break)
  • Use a tooltip that is keyboard and screen reader accessible to announce the entirety of text
  • Offer a method such as a button or toggle to "expand all titles" and "hide titles"

@GogaIV
Copy link
Copy Markdown
Contributor Author

GogaIV commented May 25, 2026

image

sum like this

@GogaIV GogaIV requested a review from leowla May 25, 2026 07:34
Copy link
Copy Markdown
Member

@leowla leowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do yarn run prettier lint to save time. We could set up a pre-commit hook to properly solve this problem but anyway this should be done in a separate PR since its not related to the dropdown.

Comment thread backend/package.json Outdated
@GogaIV GogaIV requested a review from leowla May 26, 2026 11:12
Copy link
Copy Markdown
Member

@leowla leowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐

Comment thread backend/package.json Outdated
Co-authored-by: Leo Wang <git@leowla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants