Vps 40/dropdown trunucation#409
Open
GogaIV wants to merge 5 commits into
Open
Conversation
leowla
requested changes
May 25, 2026
Member
leowla
left a comment
There was a problem hiding this comment.
It would be better to wrap text here.
https://primer.style/accessibility/patterns/truncation/#interactive-elements
Do not truncate text if it contains focusable elements such as links, buttons, and mentions/tags.
If you experience this challenge, some potential design alternatives are:
- Wrap text instead of truncate (so long as focus does not break)
- Use a tooltip that is keyboard and screen reader accessible to announce the entirety of text
- Offer a method such as a button or toggle to "expand all titles" and "hide titles"
Contributor
Author
leowla
requested changes
May 26, 2026
Member
leowla
left a comment
There was a problem hiding this comment.
You can do yarn run prettier lint to save time. We could set up a pre-commit hook to properly solve this problem but anyway this should be done in a separate PR since its not related to the dropdown.
Co-authored-by: Leo Wang <git@leowla.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Issue
drop down truncation
Solution
it was a little small i felt you could only fit 22 chars so i expanded it and added a scroll for overflow
I also added an extra quick command for lint and prettier on the side cause it saves a few seconds
Images
Risk
None
Checklist