Harden URL handling in span attributes - #1477
Draft
RhysSullivan wants to merge 1 commit into
Draft
Conversation
Strip OAuth authorization codes and CSRF state from exported span URL attributes, and sanitize user-supplied MCP endpoints before stamping them.
Contributor
Cloudflare preview
Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 114d866 | Jul 28 2026, 07:09 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 114d866 | Commit Preview URL Branch Preview URL |
Jul 28 2026, 07:09 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Telemetry spans can carry request URLs verbatim, including query strings.
Query strings are not a safe thing to put in a trace store by default: they
are attacker-influenced, vary by route, and some OAuth and integration flows
legitimately put sensitive values there.
This adds a redaction step so URL attributes are sanitised before export
rather than relying on each call site to do the right thing.
apps/cloud/src/observability/.It is the single point every span passes through, so a route added later
cannot bypass it.
url.pathispreserved so route-level debugging is unaffected. The stripped parameter
names are recorded so traces stay useful.
embed a full URL.
plugin-stamped endpoint attributes get the same treatment.
Verification
format:check,lint,typecheck,testall pass.Tests cover the processor directly and the nested-parameter case, and assert
the preserved fields survive. Verified fail-before/pass-after by reverting the
change in place. All test data is synthetic.
Follow-up
Only the cloud host installs this processor today. Other hosts do not
currently export traces, so this is not a gap now, but the placement is worth
revisiting if that changes.