Movies in lists#1165
Draft
UweTrottmann wants to merge 24 commits into
Draft
Conversation
UweTrottmann
force-pushed
the
movies-in-lists
branch
5 times, most recently
from
67e6726 to
cbf02c8
Compare
UweTrottmann
force-pushed
the
movies-in-lists
branch
6 times, most recently
from
e38cda8 to
6c16fcf
Compare
Notifications are still sent out, but the SgListFragment is using a Room query and it's change listener mechanism already.
So the strings match the actual implementation
Also change default IDs to null as expected by Room when using a nullable type for the primary key.
Also change to wait on semaphore instead of producing an unrelated error message.
UweTrottmann
force-pushed
the
movies-in-lists
branch
from
c89e64f to
159c6bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1085
Add very basic support of movies in lists.
As a movie needs to be in the database for it to be displayed in the app, for this first version it must already be added to the database: it must be in the watchlist, collection or watched.
In a future version, a movie could be added to the database if it's added to a custom list.
dev