Optimize UTIL_CreateScaledPhysObject#1880
Open
RaphaelIT7 wants to merge 1 commit intoValveSoftware:masterfrom
Open
Optimize UTIL_CreateScaledPhysObject#1880RaphaelIT7 wants to merge 1 commit intoValveSoftware:masterfrom
RaphaelIT7 wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I made this back in like 2024, though it should be merged upstream for everyone's benefit :)
This optimizes UTIL_CreateScaledPhysObject by switching it to use CPhysPolysoup which is way faster.
I've suggested this change for GMod around a week ago and has been working great there on the dev branch.
This is an old performance test from when I made it since I can't test it with the sdk when the engine keeps crashing :/
Though even in GMod it was confirmed to be significantly faster.
Test with the same 100 PhysCollide:
Old took ~880ms
New takes ~140ms