VCST-4843: Pin third-party actions to SHAs and automate updates#51
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2631b66. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pins every third-party uses: reference (non-VirtoCommerce/* owners) in .github/workflows/ and workflow-templates/ to a 40-character commit SHA with a trailing # tag comment, per GitHub's supply-chain hardening guide. Tags are mutable; SHAs are not.
16 workflow + template files re-pinned across actions/, docker/, aquasecurity/, zaproxy/ (etc.).
aquasecurity/trivy-action switched from @master to v0.36.0 SHA — the only ref previously tracking a branch.
New pinact.yaml declaring scan paths and VirtoCommerce/* ignore.
New .github/workflows/pin-check.yml — runs pinact run -check on every PR that touches workflows or templates; fails on unpinned uses: lines.
Internal VirtoCommerce/* refs (vc-github-actions, jira-upload-*, reusable workflows) are intentionally left as version-/branch-pinned — they're not third-party.
Layers automated maintenance onto the SHA pinning from #.
.github/dependabot.yml — weekly grouped github-actions updates. Dependabot reads the # tag comment, bumps SHA + comment together when upstream cuts new tags.
.github/workflows/auto-update-templates.yml — Mondays 08:00 UTC, runs pinact run -update workflow-templates/*.yml and opens a PR via peter-evans/create-pull-request. Closes the gap where Dependabot's github-actions ecosystem doesn't scan workflow-templates/.
README section documenting both flows + the contributor playbook (how to look up a SHA for a new action).
Note
Medium Risk
Primarily CI configuration changes, but it modifies many workflows and introduces automated PR creation; mis-pins or token/permissions issues could break builds or create noisy PRs.
Overview
Hardens GitHub Actions supply chain by converting third-party
uses:references in.github/workflows/andworkflow-templates/from floating tags/branches to pinned 40-char SHAs (including switchingaquasecurity/trivy-actionoff@master) and bumping the internal template/workflow version marker tov3.800.34.Adds automation to keep pins current: a new weekly grouped Dependabot config for
github-actions, a scheduledauto-update-templatesworkflow that runspinactand opens a PR for template pin bumps, and apin-checkworkflow that fails PRs if any third-party actions aren’t SHA-pinned (scoped via new.pinact.yaml, ignoringVirtoCommerce/*). Documentation inREADME.mdis updated to describe the policy and contributor workflow.Reviewed by Cursor Bugbot for commit 2b275b3. Bugbot is set up for automated code reviews on this repo. Configure here.