fix: visibility-first sweep (C1, C2, C6 from CODE_REVIEW.md)#151
Merged
Conversation
- C1: drop --retries=1 from pytest addopts and remove pytest-retry dep.
Blanket retry was masking flake rate in CI.
- C2: add `restapi` to pyright include. Surfaces 129 reportReturnType
errors for REST operations returning `_ResponseBody | None` against
`dict` annotations; these are C3 territory and will be lifted by PR 3.
- C6: replace silent `except Exception: pass` with logger.warning in
factory teardowns (8 module conftests, 21 occurrences) and test-body
cleanup blocks (12 files, 29 occurrences). Two deliberate skips:
- tests/restapi/store/test_store.py:46 — test logic (expects
validation failure; comment already explains intent)
- tests/restapi/search/test_search.py:113 — polling loop, covered
by separate C7 fix
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
restapito pyright include. Surfaces 129 reportReturnType errors for REST operations returning_ResponseBody | Noneagainstdictannotations; these are C3 territory and will be lifted by PR 3.except Exception: passwith logger.warning in factory teardowns (8 module conftests, 21 occurrences) and test-body cleanup blocks (12 files, 29 occurrences). Two deliberate skips: