VCST-2925: Add wishlist management components and end-to-end tests#167
Open
ToxaKZ wants to merge 4 commits into
Open
VCST-2925: Add wishlist management components and end-to-end tests#167ToxaKZ wants to merge 4 commits into
ToxaKZ wants to merge 4 commits into
Conversation
- Split test_wishlist.py into four focused files by scenario - Use `client=` kwarg on ShoppingListOperations/CartOperations - Move scope-selector capability probe to top of test (was mid-loop) - Replace prefix-based cleanup with per-test created_ids/try-finally - Modal components now use Component(root: Locator) contract - Reuse utils.polling_utils.poll_until instead of custom sleep loops - Match wishlist/cart GraphQL mutations by operation name - Use explicit kwarg constructors on AccountListDetailsPage and ProductPage Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Add Callable type hint to open_add_to_list parametrize arg - Move modal locators onto AccountListsPage as settings_modal / delete_modal - Wrap wishlist and cart teardown blocks in independent try/except - Use data-test-id locator selector for AddToWishlistsModal checkboxes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Lenajava1
approved these changes
May 28, 2026
Collaborator
|
Hi Anton, I pushed two follow-up commits on top of your Refactor (commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added E2E coverage for wishlist add/remove/list-management/cart flows.
Changes
Verification
python -m compileall page_objects tests\e2e\test_wishlist.py