Add sample file support to generator configuration and orchestration#4
Merged
Conversation
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughThe PR adds generator sample-file replay: case-relative files are preloaded and cycled verbatim (with optional RFC3164 timestamp rewriting). Changes span config schema/validation, generator runtime, Docker Compose wiring and tests, and runner case-dir plumbing. ChangesSample File Replay Feature
Estimated code review effort🎯 4 (Complex) | ⏱️ ~40 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@containers/generator/main.go`:
- Around line 833-847: The sample file is being loaded inside the per-connection
path (the block that calls loadSampleLines when cfg.SampleFile != ""), causing
repeated parallel reads; move the loadSampleLines call to the program
startup/config initialization and store the resulting [][]byte on the config
(e.g., add a field like Config.SampleLines) so workers reuse it; update
sendLinesConn (and any callers) to check cfg.SampleLines instead of reloading,
remove the per-connection load logic, and keep the same error checks (empty
file) during startup so workers assume preloaded data.
In `@internal/config/case.go`:
- Around line 196-207: Validate that SampleFile is a case-relative path and
reject absolute or escaping paths: in the Case struct validation (where
SampleFile is defined) ensure filepath.IsAbs(SampleFile) is false, clean the
path with filepath.Clean, then compute rel, err := filepath.Rel(CaseDir,
filepath.Join(CaseDir, cleaned)) and require err == nil and that rel does not
start with ".." before accepting; return a validation error otherwise so the
join/mount logic used by the Docker generator code (the join logic that consumes
CaseDir + SampleFile) cannot escape the case directory.
In `@internal/orchestrator/docker.go`:
- Around line 853-857: The code silently skips mounting/setting env when
g.SampleFile is set but cfg.CaseDir is empty and does not validate the sample
path; update the logic that calculates sampleHost/sampleDst/sampleFile
(referencing g.SampleFile and cfg.CaseDir in the docker compose preparation
function) to fail fast: if g.SampleFile is non-empty then resolve the host path
by joining cfg.CaseDir and g.SampleFile (or a singular/plural resolver you
provide), verify the resulting path exists and is a regular file (return an
error if CaseDir is empty or the file is missing/not regular), and only then set
sampleHost, sampleDst and sampleFile; apply the same validation for the parallel
block around the lines handling the other sample logic (the 914-919 region) so
compose rendering never proceeds with an unresolved sample_file.
In `@internal/runner/runner.go`:
- Around line 222-223: The CaseDir constructed with
filepath.Join(r.opts.CasesDir, tc.Name) should be resolved to an absolute path
before handing it to orchestration; change the assignment that sets CaseDir to
use filepath.Abs (or filepath.Join followed by filepath.Abs) on r.opts.CasesDir/
tc.Name so the host bind mount for sample_file always points to the correct
absolute location; update the same pattern in all four run paths where CaseDir
is set (instances referencing CaseDir, r.opts.CasesDir, tc.Name and
filepath.Join) so orchestration receives an absolute path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e52b1794-0b9c-442b-ac45-a7ad487ea03b
📒 Files selected for processing (5)
containers/generator/main.gointernal/config/case.gointernal/orchestrator/compose_render_test.gointernal/orchestrator/docker.gointernal/runner/runner.go
…re existence for generator
Deploying pipebench with
|
| Latest commit: |
806fae8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://12492e0a.pipebench.pages.dev |
| Branch Preview URL: | https://generator-inputfile-update.pipebench.pages.dev |
…pdate # Conflicts: # internal/config/case.go # internal/orchestrator/compose_render_test.go # internal/orchestrator/docker.go
Member
|
@coderabbitai full review |
✅ Action performedFull review finished. |
yusufozturk
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce support for a sample input file in the generator configuration, allowing the generator to replay file contents instead of synthesizing lines. This update includes necessary changes to the configuration structure and adds tests to verify the functionality.
Summary by CodeRabbit
New Features
Bug Fixes / Validation
Tests
Chores