fix(logback): drop '--' from comment to fix SAXParseException at startup

[VirusAlex]

Bug

PR #65 added a date to the logback.xml timestamp pattern with an explanatory comment. The comment included the literal token kubectl logs --previous to motivate the choice. XML forbids the -- sequence inside comments — it terminates the comment parser early.

At every JVM startup since v0.4.0:

ch.qos.logback.core.joran.spi.JoranException: Problem parsing XML document. ...
Caused by: org.xml.sax.SAXParseException; ... line 9 column 46;
  The string "--" is not permitted within comments.

Logback fell back to its default appender (no pattern, no level overrides) and the app continued with degraded logging. Reported by VirusAlex on a v0.4.1 live docker pull test.

Why it slipped through

• ArchUnit doesn't validate XML.
• The only mvn-test path that exercises logback init is the Jetty-using server tests, which fail under our Windows CI env for unrelated loopback reasons.
• The CI build-and-package step packages the jar but never actually starts the JVM with logback.xml on the classpath.
• Local mvn test uses logback's default config, never reads our resource.

In short: no automated path even tries to load this file.

Fix

Replaced the verbose comment (which also did unnecessary scope creep into Kubernetes / journalctl framing — NetCopy targets two trusted hosts on a LAN, not k8s) with a tight one-liner that doesn't reference command-line flags.

-            <!--
-                ISO date in the timestamp so a `grep` across days isn't ambiguous
-                (HH:mm:ss alone repeats every 24h). Container log consumers like
-                Docker's json-file driver also stamp lines with the host's wall
-                clock, but those timestamps don't survive when the user pipes
-                logs through `kubectl logs --previous`, journalctl exports,
-                or the GitHub Actions UI's run logs.
-            -->
+            <!-- ISO date in the timestamp so `grep` across days isn't
+                 ambiguous (HH:mm:ss alone repeats every 24h). -->

Verification

• xmllint-equivalent validation: XML parses cleanly via .NET XmlDocument.
• java -jar netcopy.jar --version starts with no SAXParseException and prints version line.
• CI green.

Follow-up

After this lands I'll move the v0.4.1 tag onto the new HEAD so the GHCR / GH Release artifacts are rebuilt with the working logback config. The currently-published :0.4.1 works (logback's default appender prints lines, just without the configured pattern), but it'll keep emitting that JoranException stack trace at every startup until users repull. Force-moving the tag is fine here — the release is a v0.x pre-release and only ~one user has pulled it.

🤖 Generated with Claude Code