test: add funnel chart spec coverage#298
Open
cat0825 wants to merge 1 commit into
Open
Conversation
Add unit coverage for getChartSpecWithContext when chartType is Funnel Chart, including descending measure sort, color/value cell aliases, and value-over-y field preference. Fixes VisActor#221
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Fixes #221
💡 Background and solution
Background
Add unit coverage for
getChartSpecWithContext()whenchartTypeis Funnel Chart, matching the existing chart-type unit-test series.Solution
Added
packages/vmind/__tests__/unit/getChartSpecWithContext_funnel.test.tscovering:type,categoryField,valueField, label, data id)cell.y)color/valuecell aliases mapping tocategoryField/valueFieldcell.valueovercell.yforvalueFieldwhile still sorting bycell.ywhen present📝 Changelog
☑️ Self-Check before Merge