Release Candidate Version 1.1 - #196
Conversation
There was a problem hiding this comment.
Pull request overview
Release candidate v1.0.1 update focused on the JS runtime/UI object layer: new object types (ProgressBar/RangeSlider/DivUnique), updated DOM/Bootstrap rendering, button request-method handling, and global variable/source-object integration.
Changes:
- Updated XMLRPC request defaults/headers and introduced button-controlled request method selection.
- Refactored several UI components to use Bootstrap list-group/card patterns and shortened/overridden DOM IDs.
- Added new system objects:
DivUnique,ProgressBar, andRangeSlider, plus global var set/get plumbing.
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| www/sysXMLRPCRequest.js | Changes XMLRPC request defaults (GET) and request URL/header construction. |
| www/sysSourceObjectHandler.js | Implements GlobalVar source-object resolution via sysFactory.getGlobalVar. |
| www/sysObjTreeSimple.js | Bootstrap-based TreeSimple refactor (list-group + icon behavior + container changes). |
| www/sysObjTabContainer.js | Adjusts DOM ID handling/initialization for tab containers. |
| www/sysObjSQLText.js | Tweaks post-icon HTML formatting for text rendering. |
| www/sysObjRangeSlider.js | Adds new RangeSlider system object (input[type=range]). |
| www/sysObjProgressBar.js | Adds new ProgressBar system object with percent rendering. |
| www/sysObjOpenCloseContainer.js | Switches header text rendering to sysObjSQLText and updates ID handling. |
| www/sysObjList.js | Enables override DOM object IDs for list instances. |
| www/sysObjFormfieldList.js | Adds DOM ID overrides + SetDataMapping support + validation refactors. |
| www/sysObjFormfieldItem.js | Formatting/alignment changes in formfield item text constructor. |
| www/sysObjFileUpload.js | Sets ObjectID from ID and fixes a missing semicolon in progress rendering. |
| www/sysObjDiv.js | Refactors Div constructor formatting and adds sysObjDivUnique. |
| www/sysObjContextMenu.js | Refactors context menu structure to a Bootstrap list-group + hover highlighting. |
| www/sysObjButtonInternal.js | Adds DOM ID override + object ID setting and clarifies property comments. |
| www/sysObjButtonCallback.js | Adds DOM ID override + object ID setting and clarifies property comments. |
| www/sysObjButton.js | Reorders click processing and adds request-method selection + new actions (set/setglobalvar). |
| www/sysFormfieldValidate.js | Updates group validation fallback to UserValidateGroup and adds debug logging. |
| www/sysFactory.js | Registers new object types and adds setGlobalVar. |
| www/sysBaseObject.js | Minor formatting/spacing change in object-type lookup section. |
| www/sysAsyncNotifyIndicatorItem.js | Adjusts Bootstrap styling classes for async notify indicator items. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@copilot Please do the following: Base BehaviourCurrently a single system object (prefixed with This makes it possible for each object to handle its own routines for an objects internal data manipulation. Object RelationshipRecursive "Object Relationship" is handled by Recursive Data Getter and SetterCurrently it is only possible to set a single objects data. It must be possible to do getting and setting in a recursive way, appending is only possible to a single object, for appenfing, nothing should change / must be done. Recursive SetterThe RuntimeSetDataFunc must be modified, so that its input parameter JSON can be set hierarchical / recursive. The following example data shows a This is a simple example, imagine a more complex setup with two container objects: Recursive GetterEach object must also have the possibility to get data automatically in a recursive way. The obect hierarchy is already known by the system with Objects containing no data get or set references So the recursive loop must process all obect instances (starting with the selected root object: This must return only the hierarchical JSON data without the "ObjectIDs" definitions (setter). ProposalsPlease propose some integration approaches. |
... Here are two concrete integration approaches. Both build on the existing Approach A — Two dedicated recursive helpers on
|
|
@copilot please implement Recommendation: Approach B, but modify it, so that it is possible at a specified setter |
Implemented in commit Getter — Setter —
{
"ObjectIDs": {
"Container1": {
"ObjectIDs": {
"ListA": { "Action": "set", "Data": [...] },
"ListB": { "Action": "append", "Data": [...] }
}
}
}
}All existing |
|
@copilot please a) add 1 example in |
Done in commit a)
The new example is also listed in b)
|
Pull Request
Description
Release Candidate
v1.1.DivUnique,ProgressBarandRangeSliderObject TypesPOSTtoGETPOST, addRequestMethodProperty (object.json) for all Button TypesType of Change