Resolve pull when read is successful#222
Merged
Merged
Conversation
It appears that the "Note" that immediately returning a resolved Promise is required to allow a stream to be cancelled while there is a pull() in progress was incorrect. The steps are updated to return a Promise that is resolved when the pull() succeeds. Fixed #221.
github-actions Bot
added a commit
that referenced
this pull request
Feb 18, 2026
SHA: 11f6161 Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sheikhharis50
pushed a commit
to Sheikhharis50/neurobrowser
that referenced
this pull request
May 16, 2026
WICG/serial#222 updates the pull algorithm to return a Promise that is resolved when the read is complete. This prevents Pull() from being called again until the previous read has completed. The original code was written with the belief (now apparently untrue) that Cancel() would not be called until the Promise returned by Pull() was resolved. Fixed: 485286889 Change-Id: Id118be8f1e421e1c64c998f8c227ff5e73638bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7586497 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/main@{#1587363}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that the "Note" that immediately returning a resolved Promise is required to allow a stream to be cancelled while there is a pull() in progress was incorrect. The steps are updated to return a Promise that is resolved when the pull() succeeds.
Fixed #221.