[Relaxed SIMD] Fix validation and fuzzer handling - #8967
Merged
Conversation
kripken
commented
Aug 4, 2026
kripken
commented
Member
- An opcode was not noted as requiring the feature.
- Like NaNs, we can't optimize wasms and then compare them, if relaxed SIMD is enabled.
aheejin
approved these changes
Aug 4, 2026
Comment on lines
+867
to
+868
| # With nans or relaxed SIMD, VM differences can confuse us, so only very | ||
| # simple VMs can compare to themselves after binaryen opts in that case. |
Member
Author
There was a problem hiding this comment.
Hmm, good question, I guess only the binaryen interpreter itself, so this wasn't very clear. I rewrote it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.