Add BYN_WARN_UNUSED macro and apply to Name and IString - #8973
Open
sbc100 wants to merge 1 commit into
Open
Conversation
Define `BYN_WARN_UNUSED` using `[[gnu::warn_unused]]` for GCC/Clang and fallback for other compilers. Annotating `IString` and `Name` with this attribute allows compilers to report unused variable diagnostics for default-constructed instances regardless of non-trivial constructors. Followup to #8972. Once this lands we can extend this to other types to get better coverage.
sbc100
requested review from
aheejin and
kripken
and removed request for
a team
August 5, 2026 18:32
kripken
reviewed
Aug 5, 2026
| namespace wasm { | ||
|
|
||
| struct IString { | ||
| struct BYN_WARN_UNUSED IString { |
Member
There was a problem hiding this comment.
This feels odd to me, to scatter these throughout the codebase. Is there no global flag we can set?
Member
Author
There was a problem hiding this comment.
I mean its kind of like llvm/llvm-project#203084.
If there was a flag I guess it would be something like "-falways-assume-ctors-have-no-side-effects" but I'm pretty sure that is never always true so you wouldn't want it to be global.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define
BYN_WARN_UNUSEDusing[[gnu::warn_unused]]for GCC/Clang and fallback for other compilers. AnnotatingIStringandNamewith this attribute allows compilers to report unused variable diagnostics for default-constructed instances regardless of non-trivial constructors.Followup to #8972.
Once this lands we can extend this to other types to get better coverage.