[ci] Fix spec publishing in forks - #2225
Open
kmiller68 wants to merge 1 commit into
Open
Conversation
publish-spec lists ensure-wasm-latest in its needs, but that job only runs in WebAssembly/spec. A job whose needs include a skipped job is skipped as well, so forks (i.e. proposal repos) stopped publishing their rendered spec to GitHub Pages entirely once they picked up the ensure-wasm-latest job. Guard publish-spec on nothing having failed instead, which tolerates the skipped job while still blocking publication when a build or the wasm-latest check fails.
Author
|
I'm not 100% sure this is correct but it came up while I was working on automatically creating diffs for proposals. https://github.com/kmiller68/spec/actions/runs/31501085024 and seemed to be fixed with this PR: https://github.com/kmiller68/spec/actions/runs/31504405268 |
Author
tlively
reviewed
Aug 11, 2026
tlively
left a comment
tlively
left a comment
Member
There was a problem hiding this comment.
Makes sense, thanks. Do we also need to remove ensure-wasm-latest from the needs list?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish-spec lists ensure-wasm-latest in its needs, but that job only runs in WebAssembly/spec. A job whose needs include a skipped job is skipped as well, so forks (i.e. proposal repos) stopped publishing their rendered spec to GitHub Pages entirely once they picked up the ensure-wasm-latest job.
Guard publish-spec on nothing having failed instead, which tolerates the skipped job while still blocking publication when a build or the wasm-latest check fails.