to main#207
Merged
Merged
Conversation
Reflects the master->main branch rename. BUILD_BRANCH is a template default in .env.example only; not consumed by committed code. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Maria's Apperson review #1/#4/#5: the coupon graphic, several slideshow photos, and the "Accepted Credit Cards" graphic were broken because they lived in static/imgs/ — which nothing serves (Vite serves public/, server.js serves dist/, and the build never copied static/). Every static/imgs/... URL 404'd, so the browser showed alt text instead. - Move static/imgs/* -> public/imgs/ (Vite serves it at /imgs/...); the build now emits them into dist/imgs/ for prod - Update all refs: ../static/imgs/X, ../../static/imgs/X, /static/imgs/X -> /imgs/X - Move static/*.scss -> src/styles/ to match the other frontends; fix the main.tsx import - Drop the duplicate static/favicon.ico (public/favicon.ico kept) - Delete static/; update package.json files list + point stylelint at src/ Fixes the missing coupon (#1), local slideshow photos (#4), and credit cards graphic (#5). Remaining review items (#2 fonts, #3 slideshow timing, #6 Facebook link) are separate follow-ups. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Remaining Apperson review items: - #2 .header-text used TrajanProRegular (never loaded) -> fell back to serif/Times; switch to the loaded Habibi sans-serif so all text matches - #3 slideshow autoplaySpeed 3000 -> 5000 (slower) and waitForAnimate:false so the first photo no longer lingers longer than the rest - #6 remove the Facebook link (Unofficial page, no header image, one post) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
chore: update .env.example BUILD_BRANCH master->main
…tyles-to-src # Conflicts: # package-lock.json # package.json
…o-src fix: Maria's Apperson review — all 6 items (graphics, fonts, slideshow, FB link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.