Skip to content

Fix typo for --test parsing #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joyeecheung wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typo for --test parsing #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ const printHelp = cliParams.delete("help");
const dumpTestList = cliParams.delete("dumpTestList");

if (cliArgs.length) {
let tests = cliParams.has("test") ? cliParams.get("tests").split(",") : []
let tests = cliParams.has("test") ? cliParams.get("test").split(",") : []
tests = tests.concat(cliArgs);
cliParams.set("test", tests.join(","));
}
Expand Down
7 changes: 7 additions & 0 deletions tests/run-shell.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,13 @@ const TESTS = [
return runCLITest("Grouped with Details", shell_binary, "SunSpider", "--group-details");
},
},
{
name: "Test Flag With Positional Args",
tags: ["all", "main", "test-flag"],
run(shell_binary) {
return runCLITest("Test Flag With Positional Args", shell_binary, "--test=proxy-mobx", "proxy");
},
},
{
name: "Disabled Suite",
tags: ["all", "disabled"],
Expand Down