Harden portable export artifact publishing#4918
Merged
Merged
Conversation
# Conflicts: # src/CodeIndex/Cli/CliFlagSchema.cs
Widthdom
marked this pull request as ready for review
July 27, 2026 01:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--overwriteis explicit, create source-bearing archives privately, and publish with platform no-clobber rename primitives plus a safe hard-link fallback.Validation
dotnet restore CodeIndex.slndotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false --no-restore(0 warnings, 0 errors; rerun after final review follow-up)dotnet test CodeIndex.sln -c Release -p:UseSharedCompilation=false --no-buildbefore the final no-clobber compatibility follow-up: net8.0 10,479 passed / 7 skipped / 0 failed; net9.0 10,006 passed / 419 skipped / 0 faileddotnet format CodeIndex.sln --verify-no-changes --no-restore --verbosity minimaldotnet run --project tools/CodeIndex.Changelog -- checkdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsoncodex review --base origin/main(two adversarial rounds; all findings addressed)Documentation
USER_GUIDE.md,DEVELOPER_GUIDE.md, andTESTING_GUIDE.md.AGENTS.md,CLAUDE.md, andAGENT_GUIDE.mdwere not changed.Changelog
changelog.d/unreleased/4827.security.md.Follow-ups
Fixes #4827