Skip to content

Report search selector population accounting - #4938

Merged
Widthdom merged 6 commits into
mainfrom
fix-issue4843
Jul 27, 2026
Merged

Report search selector population accounting#4938
Widthdom merged 6 commits into
mainfrom
fix-issue4843

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • separate source, selected, returned, selector-omitted, and limit-omitted search populations
  • preserve selector accounting for zero-result issue drafts and total-limit-exhausted recipe queries
  • keep compact and array-envelope returned counts accurate after hard byte-cap trimming
  • reject output modes that cannot represent row selectors instead of silently ignoring them

Root cause and impact

Selector stages and output limits were previously collapsed into the same result totals, and some output shapes either discarded selector accounting or retained pre-trim counts. Machine consumers can now audit selector behavior consistently across supported search and recipe outputs.

Validation

  • dotnet format CodeIndex.sln --no-restore --verify-no-changes
  • dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false --no-restore
  • related Release tests on .NET 8 and .NET 9: 16 passed per target
  • full Release solution tests: .NET 8 — 10,595 passed, 7 skipped; .NET 9 — 10,122 passed, 419 skipped
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • two Codex adversarial-review rounds; all blocking/actionable findings addressed

Documentation and changelog

  • updated English and Japanese sections in USER_GUIDE.md and DEVELOPER_GUIDE.md
  • added changelog.d/unreleased/4843.fixed.md

Follow-ups

None.

Fixes #4843

@Widthdom
Widthdom marked this pull request as ready for review July 27, 2026 23:56
@Widthdom
Widthdom merged commit e7933a8 into main Jul 27, 2026
12 checks passed
@Widthdom
Widthdom deleted the fix-issue4843 branch July 27, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report source-population and selector semantics for sampling and count mode

1 participant