Enforce the LSP session lifecycle - #4944
Merged
Merged
Conversation
Widthdom
marked this pull request as ready for review
July 28, 2026 01:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initializeresponse publication, and reject out-of-phase requests with the required JSON-RPC errorsRoot cause
Lifecycle booleans were updated only as handler side effects. The transport and alternate dispatch paths did not share a receive-ordered state machine, so queued or concurrent traffic could observe the wrong phase and shutdown did not provide one coordinated resource boundary.
Validation
dotnet restore CodeIndex.slndotnet build CodeIndex.sln -c Release --no-restore --nologo— 0 warnings, 0 errorsdotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --no-build --no-restore --filter "FullyQualifiedName~LspServerTests|FullyQualifiedName~LspServerBudgetTests"— 115 passed on net8.0 and 115 passed on net9.0dotnet format CodeIndex.sln --verify-no-changes --no-restoredotnet run --project tools/CodeIndex.Changelog -- checkProcessFrameAsync_BatchInitializeDoesNotFlowBackIntoTimedOutPriorGeneration_Issue4540_Issue4545), which passed on immediate isolated rerunDocumentation and changelog
USER_GUIDE.mdandDEVELOPER_GUIDE.mdchangelog.d/unreleased/4849.fixed.md, including the LSP shutdown and exit notifications do not stop the server loop #2830 regression relationshipFixes #4849