Expose completion metadata in ad-hoc SARIF - #4945
Merged
Merged
Conversation
# Conflicts: # DEVELOPER_GUIDE.md # src/CodeIndex/Cli/QueryCommandRunner.SearchRecipes.cs
# Conflicts: # DEVELOPER_GUIDE.md # src/CodeIndex/Cli/QueryCommandRunner.Search.cs
Widthdom
marked this pull request as ready for review
July 28, 2026 01:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The ad-hoc search path called the shared SARIF writer without run properties and applied result limits after occurrence expansion without exposing completion accounting. As a result, consumers could not distinguish complete, empty, and truncated SARIF runs or safely reproduce the query.
Validation
dotnet restore CodeIndex.sln --locked-modedotnet build CodeIndex.sln -c Release --no-restore— 0 warnings, 0 errorsdotnet format CodeIndex.sln --verify-no-changes --no-restoreindex_matches_workspace=trueA parallel full-suite run during development exposed an unrelated 5-second Unicode worker timeout; the isolated rerun and the final full suite passed. Related: #4937
Documentation and changelog
DEVELOPER_GUIDE.mdandTESTING_GUIDE.mdin both English and Japanesechangelog.d/unreleased/4844.fixed.mdCHANGELOG.md,AGENTS.md,CLAUDE.md, orAGENT_GUIDE.mdFollow-up candidates
Fixes #4844