Restore accurate C# semantic token kinds - #4950
Merged
Merged
Conversation
# Conflicts: # README.md
# Conflicts: # TESTING_GUIDE.md
Widthdom
marked this pull request as ready for review
July 28, 2026 08:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause and impact
The LSP and excerpt paths used separate coarse mappings, so C# identifiers were commonly flattened to
variable, and source-unavailable fallbacks diverged further. The shared classifier now gives clients consistent semantic kinds while retaining bounded behavior for indexed content.Validation
dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=false(0 warnings, 0 errors)dotnet format CodeIndex.sln --verify-no-changes --no-restoredotnet run --project tools/CodeIndex.Changelog -- checkgit diff --checkDocumentation and changelog
README.md,DEVELOPER_GUIDE.md, andTESTING_GUIDE.mdchangelog.d/unreleased/4852.fixed.mdFollow-up candidates
None.
Fixes #4852