Make partial find scans resumable - #4961
Merged
Merged
Conversation
Widthdom
marked this pull request as ready for review
July 28, 2026 17:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find --allcontinuation cursors at match or line boundaries for result limits, scan caps, and paged countsValidation
dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=false(0 warnings, 0 errors)dotnet build CodeIndex.sln -c Debug --no-restore -p:UseSharedCompilation=false(0 warnings, 0 errors)dotnet run --project tools/CodeIndex.Changelog -- check(33 fragments validated)dotnet format CodeIndex.sln --no-restore --include ...git diff --checkstatus --check --jsonreportsindex_matches_workspace: trueAdversarial review
Two Codex adversarial-review rounds were completed (the workflow maximum). Round 1 found and fixed cancellation propagation, out-of-range resume-line validation, and high-ordinal UTF-8 resume performance. Round 2 found and fixed row/count cursor mode separation, count/bounded-control validation, and resumed count-page authority semantics. No known actionable findings remain.
Documentation and changelog
docs/find-scan-controls.mdin English and Japanesechangelog.d/unreleased/4863.fixed.mdFollow-ups
None.
Fixes #4863