Skip to content

Fix skipped status in build notifications#62

Merged
huangminghuang merged 1 commit into
masterfrom
codex/fix-notification-skipped
May 19, 2026
Merged

Fix skipped status in build notifications#62
huangminghuang merged 1 commit into
masterfrom
codex/fix-notification-skipped

Conversation

@huangminghuang
Copy link
Copy Markdown
Contributor

Why

The Build Platforms job is optional and is expected to be skipped whenever the required builder image already exists. After PR #58, the notification action receives build-platforms:skipped along with successful discover/build jobs and reports the whole workflow notification as SKIPPED even though the workflow itself passed.

Summary

  • normalize build-platforms:skipped to success only in the notification payload
  • preserve real failure and cancelled results from the Build Platforms job

Validation

  • inspected run 26117752616 for commit 0ea07e6, where the workflow concluded success but the notification action reported SKIPPED because job-results included build-platforms:skipped
  • ran git diff --check

@huangminghuang huangminghuang requested a review from heifner May 19, 2026 18:58
@huangminghuang huangminghuang merged commit f28ed37 into master May 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants