Skip to content

Kv: drop double-scan in kv_idx_lower_bound on miss #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heifner wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Kv: drop double-scan in kv_idx_lower_bound on miss #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions libraries/chain/apply_context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,8 +1070,15 @@ int32_t apply_context::kv_idx_lower_bound(name code, uint16_t table_id,
auto itr = idx.lower_bound(boost::make_tuple(code, table_id, sv_sec));

if (itr == idx.end() || itr->code != code || itr->table_id != table_id) {
auto first = idx.lower_bound(boost::make_tuple(code, table_id));
if (first != idx.end() && first->code == code && first->table_id == table_id) {
// Seek missed inside (code, table_id). All rows of the table, if any,
// lie strictly before itr in the index, so the table is non-empty iff
// prev(itr) is in (code, table_id). itr == begin() means no rows below.
bool table_has_rows = false;
if (itr != idx.begin()) {
auto prev = std::prev(itr);
table_has_rows = (prev->code == code && prev->table_id == table_id);
}
if (table_has_rows) {
const uint32_t slot_index = kv_secondary_iterators.allocate(code, table_id);
auto& slot = kv_secondary_iterators.get(slot_index);
slot.status = kv_it_stat::iterator_end;
Expand Down