Use release-only vcpkg triplet in sysio CI#340
Open
huangminghuang wants to merge 1 commit into
Open
Conversation
heifner
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x64-linux-releasevcpkg overlay triplet withVCPKG_BUILD_TYPE=release.vcpkg-configuration.jsonand.github/vcpkg-triplets/**in the vcpkg binary cache key so cache entries are invalidated when registry or triplet behavior changes.Why this is necessary
This mirrors the CI performance issue addressed in
wire-cdtPR #55.wire-sysioalready sets-DCMAKE_BUILD_TYPE=Release, but that only controls the top-level CMake build. vcpkg was still using the defaultx64-linuxtriplet, which does not setVCPKG_BUILD_TYPE, so package builds such as LLVM and protobuf can include unnecessary Debug variants or host helper packages under the default triplet.Using
x64-linux-releasefor both target and host triplets keeps vcpkg dependency builds release-only and makes the binary cache behavior more predictable.Validation
.github/workflows/build.yamland.github/workflows/build_base.yamlwith PyYAML.jq empty vcpkg.json vcpkg-configuration.jsongit diff --checkvcpkg install --dry-run --x-manifest-root=. --triplet x64-linux-release --host-triplet x64-linux-release --overlay-triplets=.github/vcpkg-tripletsshows LLVM, protobuf, and vcpkg helper packages selected underx64-linux-release.-DCMAKE_C_COMPILER_LAUNCHER=ccacheand-DCMAKE_CXX_COMPILER_LAUNCHER=ccacheinto CMake package configure, and the generated packageCMakeCache.txtcontains both launcher settings.Notes