Skip to content

Detect unshared test namespace support #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
huangminghuang wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Detect unshared test namespace support #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,11 @@ You can invoke them by running `ctest` from a terminal in your build directory a
ctest -L "nonparallelizable_tests"
```

On Linux hosts that support user and network namespaces, CMake automatically
adds `--unshared` to tests that support it. This allows many tests that reuse
the same localhost ports to run concurrently in isolated network namespaces.
Control this with `-DSYSIO_UNSHARED_TESTS=AUTO|ON|OFF` at configure time.

#### Long-Running Tests

The long-running tests are [medium-to-large](https://testing.googleblog.com/2010/12/test-sizes.html) integration tests
Expand Down Expand Up @@ -135,4 +140,4 @@ ctest -L "long_running_tests"
© 2024 Wire Network. All rights reserved.
</td>
</tr>
</table>
</table>
41 changes: 40 additions & 1 deletion tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,48 @@ configure_file(${CMAKE_CURRENT_SOURCE_DIR}/producer_rank_test.py ${CMAKE_CURRENT
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/split_blocklog_replay_test.py ${CMAKE_CURRENT_BINARY_DIR}/split_blocklog_replay_test.py COPYONLY)
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/PerformanceHarnessScenarioRunner.py ${CMAKE_CURRENT_BINARY_DIR}/PerformanceHarnessScenarioRunner.py COPYONLY)

if(DEFINED ENV{GITHUB_ACTIONS})
set(SYSIO_UNSHARED_TESTS "AUTO" CACHE STRING "Use Linux network namespaces for tests that support --unshared. Values: AUTO, ON, OFF")
set_property(CACHE SYSIO_UNSHARED_TESTS PROPERTY STRINGS AUTO ON OFF)
string(TOUPPER "${SYSIO_UNSHARED_TESTS}" SYSIO_UNSHARED_TESTS)
if(NOT SYSIO_UNSHARED_TESTS MATCHES "^(AUTO|ON|OFF)$")
message(FATAL_ERROR "SYSIO_UNSHARED_TESTS must be AUTO, ON, or OFF")
endif()

set(SYSIO_CAN_UNSHARE_TESTS FALSE)
if(CMAKE_SYSTEM_NAME STREQUAL "Linux" AND NOT SYSIO_UNSHARED_TESTS STREQUAL "OFF")
set(SYSIO_UNSHARE_PROBE "${CMAKE_CURRENT_BINARY_DIR}/probe_unshared_tests.py")
file(WRITE "${SYSIO_UNSHARE_PROBE}" "
import pathlib
import sys
import importlib.util

libc_path = pathlib.Path(r'${CMAKE_CURRENT_SOURCE_DIR}') / 'TestHarness' / 'libc.py'
spec = importlib.util.spec_from_file_location('sysio_test_libc', libc_path)
libc = importlib.util.module_from_spec(spec)
spec.loader.exec_module(libc)

libc.unshare(libc.CLONE_NEWNET)
")
execute_process(
COMMAND python3 "${SYSIO_UNSHARE_PROBE}"
RESULT_VARIABLE SYSIO_UNSHARE_RESULT
OUTPUT_QUIET
ERROR_VARIABLE SYSIO_UNSHARE_ERROR
)
if(SYSIO_UNSHARE_RESULT EQUAL 0)
set(SYSIO_CAN_UNSHARE_TESTS TRUE)
endif()
endif()

if(SYSIO_UNSHARED_TESTS STREQUAL "ON" AND NOT SYSIO_CAN_UNSHARE_TESTS)
message(FATAL_ERROR "SYSIO_UNSHARED_TESTS=ON, but this host cannot create a user/network namespace: ${SYSIO_UNSHARE_ERROR}")
endif()

if(SYSIO_CAN_UNSHARE_TESTS)
message(STATUS "Using --unshared for tests that support network namespace isolation")
set(UNSHARE "--unshared")
else()
message(STATUS "Not using --unshared for tests; set SYSIO_UNSHARED_TESTS=ON to require it")
set(UNSHARE "")
endif()

Expand Down