REST API: Guard against missing language_packs in create_item().#11835
REST API: Guard against missing language_packs in create_item().#11835Malayt04 wants to merge 1 commit into
Conversation
When plugins_api() returns a response without a populated language_packs property — due to a partial response, no translations for installed locales, or a third-party filter — accessing $api->language_packs produces a PHP Warning and array_map() throws a Fatal TypeError on PHP 8.x, causing a spurious HTTP 500 even though the plugin install succeeded. Add an explicit is_array() check before calling array_map() so that the language-pack installation step is safely skipped when the property is absent or is not an array.
|
Hi @Malayt04! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
WP_REST_Plugins_Controller::create_item()can throw a FatalTypeErroron PHP 8.x after a successful plugin install, causing the REST endpointPOST /wp/v2/pluginsto returnHTTP 500even though the plugin files are already on disk. This patch adds a one-line defensive guard to prevent the crash.Trac ticket: https://core.trac.wordpress.org/ticket/65240